Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: 404 metadata #597

Merged
merged 6 commits into from
Oct 10, 2023
Merged

refactor: 404 metadata #597

merged 6 commits into from
Oct 10, 2023
+14 −13

Conversation

alexbarnsley
Copy link
Member

Summary

https://app.clickup.com/t/862kfem4k

requires ArkEcosystem/laravel-foundation#600

Checklist

  • I checked my UI changes against the design and there are no notable differences
  • I checked my UI changes for any responsiveness issues
  • I checked my UI changes in light AND dark mode
  • I checked my (code) changes for obvious issues, debug statements and commented code
  • I opened a corresponding card on Clickup for any remaining TODOs in my code
  • I added a short description on how to test this PR (if necessary)
  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@alexbarnsley alexbarnsley marked this pull request as ready for review October 10, 2023 12:01
@alexbarnsley
Copy link
Member Author

@ItsANameToo ignore the labels workflow, something was changed in that package 4 hours ago so now it's broken. There's already at least 1 issue on there

@alexbarnsley alexbarnsley changed the base branch from develop to rc October 10, 2023 12:21
@alexbarnsley alexbarnsley merged commit 6a2581a into rc Oct 10, 2023
9 checks passed
@alexbarnsley alexbarnsley deleted the refactor/404-metadata branch October 10, 2023 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ItsANameToo ItsANameToo ItsANameToo approved these changes

@boldninja boldninja Awaiting requested review from boldninja

@samharperpittam samharperpittam Awaiting requested review from samharperpittam

Assignees
No one assigned
Labels
refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexbarnsley @ItsANameToo